Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/etc/version is dropped from latest master builds #24

Closed
MilhouseVH opened this Issue Aug 22, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@MilhouseVH
Copy link

MilhouseVH commented Aug 22, 2015

Hi Leopold

Following the merge of #4285, the /etc/version file is no longer created (see here).

When /etc/version doesn't exist, the DevUpdate addon triggers the IOException which results in your test value being used.

You'll probably need to update the addon to extract the VERSION value from /etc/os-release and use that in place of the value you were reading from /etc/version.

I'll add a patch to tonight's test build (and include it for the next few days) so that /etc/version continues to be created as this will prevent the current DevUpdate addon from continually thinking there is a new version available. Once you've been able to push an update I'll drop the patch.

@LS80

This comment has been minimized.

Copy link
Owner

LS80 commented Aug 22, 2015

It looks like /etc/arch has also been removed which will mean that RPi2 users will inadvertently install an RPi build!

As you say I'll have to parse all of this from /etc/os-release instead.

@MilhouseVH

This comment has been minimized.

Copy link
Author

MilhouseVH commented Aug 22, 2015

Argh... should I pull the build? I can create /etc/arch temporarily if required and push an update (already had 14 installs of #0822).

@LS80

This comment has been minimized.

Copy link
Owner

LS80 commented Aug 22, 2015

It's possible to override the build type in the add-on settings, so maybe just add a note to suggest to set it to RPi2?

@MilhouseVH

This comment has been minimized.

Copy link
Author

MilhouseVH commented Aug 22, 2015

I have no idea how many are reading the forum, compared with those that just update automatically via the addon. I'll pull the build and push an #0822b with /etc/arch.

@LS80

This comment has been minimized.

Copy link
Owner

LS80 commented Aug 22, 2015

OK sounds good.

@LS80

This comment has been minimized.

Copy link
Owner

LS80 commented Aug 23, 2015

Sorry but the /etc/openelec-release removal also causes a problem for the add-on. The tar files will end up in the temp directory instead of .update

https://github.com/LS80/script.openelec.devupdate/blob/4.16.3/resources/lib/constants.py#L12

@MilhouseVH

This comment has been minimized.

Copy link
Author

MilhouseVH commented Aug 23, 2015

OK, sounds like the safest thing to do would be to revert #4285 until you have an update available.

I'll push #0822b with #4285 reverted.

@LS80

This comment has been minimized.

Copy link
Owner

LS80 commented Aug 23, 2015

Yes sounds like the safest thing. I'll get an update out ASAP.

@LS80 LS80 closed this in 4ee513b Aug 23, 2015

@MilhouseVH

This comment has been minimized.

Copy link
Author

MilhouseVH commented Aug 23, 2015

Thanks for the quick fix. I'll continue to revert #4285 for up to a week (as long as there are no other conflicting commits) to allow more users to auto-update the add-on before finally dropping the revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.