Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U/jchiang/use stack sims w 2019 42 #233

Merged
merged 7 commits into from
Oct 31, 2019

Conversation

jchiang87
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Oct 30, 2019

Coverage Status

Coverage increased (+0.08%) to 73.032% when pulling 158ab3c on u/jchiang/use_stack-sims_w_2019_42 into be926d2 on master.

@jchiang87
Copy link
Collaborator Author

Before the iers workaround:
https://travis-ci.org/LSSTDESC/imSim/builds/605136802

and after:
https://travis-ci.org/LSSTDESC/imSim/builds/605166758

Unfortunately, the error from the first (failed) build doesn't actually look the error James saw in his Grid run. I'm hoping that by using a very recent file in the workaround that he won't see the IERSRangeError

Copy link
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IERS part looks good. A single line comment before

_disable_iers_download(my_config)

would be probably be useful to the reader to tell them what is going on.

Thanks! It's great to finally have a real solution to this in the code.

@jchiang87
Copy link
Collaborator Author

Thanks! Unless I hear otherwise by 5pm PT today, I'll merge this and will make a patch release.

@jchiang87 jchiang87 merged commit 2fe87a2 into master Oct 31, 2019
@jchiang87 jchiang87 deleted the u/jchiang/use_stack-sims_w_2019_42 branch October 31, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants