From 94f680d203f009bec272dfbe85c23a2fe5578e3c Mon Sep 17 00:00:00 2001
From: Jim Chiang <jchiang@slac.stanford.edu>
Date: Tue, 20 Jun 2017 22:30:00 -0700
Subject: [PATCH 1/2] code to compute apparent magnitudes from object catalog
 data

---
 python/desc/imsim/imsim_truth.py | 68 ++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)
 create mode 100644 python/desc/imsim/imsim_truth.py

diff --git a/python/desc/imsim/imsim_truth.py b/python/desc/imsim/imsim_truth.py
new file mode 100644
index 00000000..334bf16a
--- /dev/null
+++ b/python/desc/imsim/imsim_truth.py
@@ -0,0 +1,68 @@
+"""
+Tools to compute the apparent magnitudes from the SED, mag_norm,
+redshift, and reddening info in the input imsim object catalogs.
+"""
+from __future__ import absolute_import, print_function
+import os
+import copy
+from collections import OrderedDict
+import lsst.sims.photUtils as photUtils
+import lsst.utils as lsstUtils
+
+__all__ = ['ApparentMagnitudes']
+
+# Create class-level attributes.
+_bandpasses = dict()
+for band_name in 'ugrizy':
+    throughput_dir = os.path.join(lsstUtils.getPackageDir('throughputs'),
+                                  'baseline', 'total_%s.dat' % band_name)
+    _bandpasses[band_name] = photUtils.Bandpass()
+    _bandpasses[band_name].readThroughput(throughput_dir)
+_control_bandpass = photUtils.Bandpass()
+_control_bandpass.imsimBandpass()
+
+class ApparentMagnitudes(object):
+    """
+    Class to compute apparent magnitudes for a given rest-frame SED.
+    """
+    bps = _bandpasses
+    control_bandpass = _control_bandpass
+    def __init__(self, sed_name, max_mag=1000.):
+        """
+        Read in the unnormalized SED.
+        """
+        sed_dir = lsstUtils.getPackageDir('sims_sed_library')
+        self.sed_unnormed = photUtils.Sed()
+        self.sed_unnormed.readSED_flambda(os.path.join(sed_dir, sed_name))
+        self.max_mag = max_mag
+
+    def __call__(self, obj_pars, bands='ugrizy'):
+        sed = copy.deepcopy(self.sed_unnormed)
+        fnorm = sed.calcFluxNorm(obj_pars.magNorm, self.control_bandpass)
+        sed.multiplyFluxNorm(fnorm)
+
+        a_int, b_int = sed.setupCCMab()
+        if obj_pars.internalAv != 0 or obj_pars.internalRv != 0:
+            # Apply internal dust extinction.
+            sed.addCCMDust(a_int, b_int, A_v=obj_pars.internalAv,
+                           R_v=obj_pars.internalRv)
+
+        if obj_pars.redshift > 0:
+            sed.redshiftSED(obj_pars.redshift, dimming=True)
+
+        if obj_pars.galacticAv != 0 or obj_pars.galacticRv != 0:
+            # Apply Galactic extinction.
+            sed.addCCMDust(a_int, b_int, A_v=obj_pars.galacticAv,
+                           R_v=obj_pars.galacticRv)
+
+        mags = OrderedDict()
+        for band in bands:
+            try:
+                mags[band] = sed.calcMag(self.bps[band])
+            except StandardError as eObj:
+                if str(eObj).startswith('This SED has no flux'):
+                    mags[band] = self.max_mag
+                else:
+                    raise eObj
+
+        return mags

From 2f1381d104ae78c4f7018f668734750d4984f88a Mon Sep 17 00:00:00 2001
From: Jim Chiang <jchiang@slac.stanford.edu>
Date: Wed, 21 Jun 2017 08:43:53 -0700
Subject: [PATCH 2/2] add unit test; fix exception handling

---
 python/desc/imsim/imsim_truth.py |  2 +-
 tests/test_imsim_truth.py        | 34 ++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 tests/test_imsim_truth.py

diff --git a/python/desc/imsim/imsim_truth.py b/python/desc/imsim/imsim_truth.py
index 334bf16a..2558878c 100644
--- a/python/desc/imsim/imsim_truth.py
+++ b/python/desc/imsim/imsim_truth.py
@@ -59,7 +59,7 @@ def __call__(self, obj_pars, bands='ugrizy'):
         for band in bands:
             try:
                 mags[band] = sed.calcMag(self.bps[band])
-            except StandardError as eObj:
+            except Exception as eObj:
                 if str(eObj).startswith('This SED has no flux'):
                     mags[band] = self.max_mag
                 else:
diff --git a/tests/test_imsim_truth.py b/tests/test_imsim_truth.py
new file mode 100644
index 00000000..db993536
--- /dev/null
+++ b/tests/test_imsim_truth.py
@@ -0,0 +1,34 @@
+from __future__ import print_function
+import os
+import unittest
+import desc.imsim
+import desc.imsim.imsim_truth as imsim_truth
+
+class ApparentMagnitudesTestCase(unittest.TestCase):
+    "Test case class for ApparentMagnitudes class."
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def test_magnitudes(self):
+        instcat = os.path.join(os.environ['IMSIM_DIR'], 'tests',
+                               'tiny_instcat.txt')
+        commands, objects = desc.imsim.parsePhoSimInstanceFile(instcat)
+
+
+        obj = objects.iloc[0]
+        app_mags = imsim_truth.ApparentMagnitudes(obj.sedFilepath)
+        mags = app_mags(obj)
+        self.assertAlmostEqual(mags['u'], 25.948024179976176)
+        self.assertAlmostEqual(mags['r'], 22.275029634051265)
+
+        obj = objects.iloc[8]
+        app_mags = imsim_truth.ApparentMagnitudes(obj.sedFilepath)
+        mags = app_mags(obj)
+        for band in mags:
+            self.assertAlmostEqual(mags[band], 1000.)
+
+if __name__ == '__main__':
+    unittest.main()