U/jrbogart/snana support #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include commit recently merged to main which github thought might conflict (but doesn't really)
2. Use "sncosmo" subdirectory of skycatalog root rather than "reorg" in __main__ tests because "reorg" doesn't have files for all needed healpixels
skyCatalogs - pass path of snana sed file to SnanaCollection
snana_object - move caching of sed file in SnanaCollection to separate
routine, not __init__
Add temporary routine SnanaObject._read_nearest_sed
as a stopgap until real interpolation code can be
written
Note also catalog_creator was modified in previous commit to use extinction column utilities
JoanneBogart
force-pushed
the
u/jrbogart/snana_support
branch
from
bebacd3
to
5fbbf92
Compare
jchiang87
requested changes
Oct 10, 2023
jchiang87
approved these changes
Oct 11, 2023
skycatalogs/objects/snana_object.py
Outdated
| if index == 0: | ||
| mjd_ix_l = mjd_ix_u = 0 | ||
| elif index == len(mjds): | ||
| mjd_ix_l = mjd_ix_u = last_ix |
There was a problem hiding this comment.
last_ix is undefined. Looks like this should be
mjd_ix_l = mjd_ix_u = index - 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides standard skyCatalogs API for SNANA-generated catalogs.
Expect flux calculation to be improved in the future.