Preserve user-specified file extensions when loading and saving #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the behavior of the read*() and write*() functions to allow passing file names with different suffixes. As a consequence, the patch also fixes the FileNotFoundError exception when loading files with the ".parq" and ".parquet" suffixes. Overall, the new behavior of the functions is the following: - Passing file names without suffixes: behavior stays the same (file format is deduced by the data type where applicable). - Passing file names with the default suffixes for some corresponding table type: behavior stays the same. - Passing file names with non-default suffixes for some corresponding table type: user-defined suffix is now preserved and is not overwritten anymore.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
===========================================
- Coverage 100.00% 99.67% -0.33%
===========================================
Files 8 8
Lines 618 623 +5
===========================================
+ Hits 618 621 +3
- Misses 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eacharles
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #61.
This patch changes the behavior of the read*() and write*() functions to allow passing file names with different suffixes.
As a consequence, the patch also fixes the FileNotFoundError exception when loading files with the ".parq" and ".parquet" suffixes.
Overall, the new behavior of the functions is the following: