Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow no drawing of CI #58

Closed
3 tasks done
LSYS opened this issue Feb 10, 2023 · 0 comments · Fixed by #61
Closed
3 tasks done

Allow no drawing of CI #58

LSYS opened this issue Feb 10, 2023 · 0 comments · Fixed by #61
Labels
Next Release To work on for new version release Type: Enhancement

Comments

@LSYS
Copy link
Owner

LSYS commented Feb 10, 2023 •
edited
Loading

Would be nice to allow no drawing of the confidence intervals directly from the API. (A hack is to convert the ll and hl to be the same as the estimate.)

One solution is to allow ll and hl to be None.

Another solution is a new option drawci that is True by default but can be set to False.

  • Add new option
  • Update args validation
  • Update docs: ll and hl no longer required(?)
@LSYS LSYS added Type: Enhancement Next Release To work on for new version release labels Feb 10, 2023
LSYS added a commit that referenced this issue Feb 16, 2023
@LSYS
Allow no drawing of CI (#58)
03380e3
LSYS added a commit that referenced this issue Mar 3, 2023
@LSYS
Update options (#58)
b384f05
LSYS added a commit that referenced this issue Mar 3, 2023
@LSYS
Bump to v0.3.0 (#58)
67d6ebd
@LSYS LSYS mentioned this issue Mar 3, 2023
Merged
@LSYS LSYS closed this as completed in #61 Mar 3, 2023
LSYS added a commit that referenced this issue Mar 3, 2023
@LSYS
Allow no drawing of CI (#61)
30f1eef 
* Allow no drawing of CI (#58)

* Update CI.yml

* Update nb.yml

* Update options (#58)

* Increase images

* Bump to v0.3.0 (#58)
LSYS added a commit that referenced this issue Apr 6, 2023
@LSYS
Sync (#69)
33ac52f 
* Allow no drawing of CI (#61)

* Allow no drawing of CI (#58)

* Update CI.yml

* Update nb.yml

* Update options (#58)

* Increase images

* Bump to v0.3.0 (#58)

* Patch (#68)

* Update branches in workflows
* Replacing append with concat in Pandas (#66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Next Release To work on for new version release Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow no drawing of CI LSYS/forestplot
1 participant
@LSYS