-
-
Notifications
You must be signed in to change notification settings - Fork 164
Upgrade to 1.34.0 (and websockets 10) sockets connect, but no data received #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the well prepared issue! I use websockets 10 with ubwa 1.34.0 on linux and it works fine.. Also https://www.lucit-development.co/unicorn-binance-websocket-api.html is running 1.34 with websockets 10 on a Debian system with Python 3.8.0... python-binance has similar issues.... Can we determin if this is a macos thing? |
As mentioned in this issue and also in It seems to be related to future endpoints only? |
I only use Futures, so I'm not sure if it's also related to other markets. |
Both these mentioned systems use Ubuntu? #196 references Debian and Windows 10 having the same issue. |
thanks for the tips. the commonality seems to be futures endpoint. please try on of the examples for spot and report if they works in your setup where futures doesnt work: https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api#examples |
Oh, I see. So your system are not using Futures then?
It seems limited to futures. Spot seems to work just fine: exchange="binance.com"
exchange="binance.com-futures"
|
Made the same test.... everything works except futures... |
yess. everything works except futures... #196 That's what I was trying to say in the post. |
I think a good next step is to analyse websocket headers of a working and non working endpoint and look for differences. i am busy this week .... |
@June911 Sorry, I overlooked that this only concerns futures. |
Test with websockets 10.0binance.com-futures: NOT WORKING
binance.com: WORKING
|
Test with websockets==9.1binance.com-futures: WORKING
binance.com: WORKING
|
Answer from Binance:
And websockets lib has merged a commit for better compatibility: python-websockets/websockets#1067 So if websockets release an upgrade or if binance future endpoints are upgraded we can turn on compression for future endpoint again. |
Check this or we will delete your issue. (fill in the checkbox with an X like so: [x])
#196 is very loosely related.
Select one:
Environment
What kind of internet connection do you have?
Average system load (CPU)
Hardware specification
Operating System? (include version)
Options
Which endpoint do you connect?
Python Version Requirement
Exact Python Version?
Pip Version?
Dependencies
Run
pip list > pip_list.txt
and upload the file.list.txt
UNICORN Binance WebSocket API Version?
Description of your issue
1.34.0 does not receive data while using websockets 10. Downgrading to websockets 9.1 works fine.
Attaching first 500 lines of debugs for sockets 9.1 and sockets 10.0 run.
ws10.txt
ws91.txt
Websockets 10:
Downgrade to websockets 9.1:
Downgrade output provided, as well as
print_summary()
to illustrate input after downgrade.The text was updated successfully, but these errors were encountered: