Skip to content

Wrong stream_buffer_byte_size calculation #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
7 of 12 tasks
DaWe35 opened this issue May 1, 2020 · 1 comment · Fixed by #52
Closed
7 of 12 tasks

Wrong stream_buffer_byte_size calculation #51

DaWe35 opened this issue May 1, 2020 · 1 comment · Fixed by #52
Assignees
@oliver-zehentleitner
Labels
bug Something isn't working

Comments

@DaWe35
Copy link
Contributor

DaWe35 commented May 1, 2020

I don't know, how stream_buffer_byte_size calculated, but I think it shows wrong value.
I received 1155656 packets (1.25 GB), but 496316 item is in the buffer.
kép
496316 / 1155656 = 0.429, so 42% of my packets are in the buffer.
1250 MB * 0.429 = 536 MB, so the real buffer size is around 536 MB. I checked top, and it says the python script uses ~600 MB RAM, so my calculation could be good.

  • I have searched for other issues with the same problem or similar feature requests.

Select one:

  • Bug
  • Feature Request
  • Technical Help
  • Other

Environment

  • Are you using the module on a VPS or other Cloud hosting?
  • If so, have you tried running the code on your local machine?
  • Are you using the module on a Raspberry Pi?

Operating System? (include version)

  • macOS
  • Windows
  • Linux

Python Version Requirement

  • I am using Python 3.5.3 or above
@DaWe35 DaWe35 added the bug Something isn't working label May 1, 2020
@DaWe35 DaWe35 changed the title Memory buffer size estimation Wrong stream_buffer_byte_size calculation May 1, 2020
@oliver-zehentleitner
Copy link
Member

Its done here https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/blob/master/unicorn_binance_websocket_api/unicorn_binance_websocket_api_manager.py#L1456

I will take a look at it! Thank you!

@oliver-zehentleitner oliver-zehentleitner linked a pull request May 2, 2020 that will close this issue
Fix #51 wrong stream_buffer_byte_size calculation #52
Merged
@oliver-zehentleitner oliver-zehentleitner added this to the 1.13.0 milestone May 2, 2020
oliver-zehentleitner added a commit that referenced this issue May 3, 2020
@oliver-zehentleitner
Merge pull request #52 from DaWe35/stream_buffer_size
f96a861 
Fix #51 wrong stream_buffer_byte_size calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliver-zehentleitner oliver-zehentleitner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #51 wrong stream_buffer_byte_size calculation
2 participants
@DaWe35 @oliver-zehentleitner