Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give streams a name #60

Closed
oliver-zehentleitner opened this issue May 6, 2020 · 1 comment
Closed

Give streams a name #60

oliver-zehentleitner opened this issue May 6, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@oliver-zehentleitner
Copy link
Member

oliver-zehentleitner commented May 6, 2020

Is your feature request related to a problem? Please describe.
To identify streams its cool to have labels and show them instead of the stream_id in print_summary()

Describe the solution you'd like

  1. Add a parameter like create_stream("trade", "btcusdt", stream_label="trades")
  2. Add a method to get and set/rm the label of a stream.
  3. If stream_label is not None then show it instead of the stream_id in print_summary()
  4. Change the column name "stream_id" to "stream_id/stream_label"
  5. Add/modify docstrings

Describe alternatives you've considered

Additional context

@oliver-zehentleitner oliver-zehentleitner added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2020
@oliver-zehentleitner oliver-zehentleitner self-assigned this May 6, 2020
@oliver-zehentleitner
Copy link
Member Author

oliver-zehentleitner commented May 7, 2020

Added

  • new parameter stream_label in manager.create_stream()issue #60
  • manager.get_stream_label() issue #60
  • manager.get_stream_id_by_label() issue #60
  • manager.set_stream_label() issue #60
  • added stream_label to manager.print_stream_info() issue #60
  • added stream_label to manager.print_summary() issue #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant