Skip to content

Fixed exception that thrown when api key is real but was deleted from… #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

Flowelfox
Copy link
Contributor

Description

When api key is real but was deleted from binance account then api returns dict with code -2008 and message "Invalid Api-Key ID".
To prevent library throw AttributeError on parsing uri, which is dict when this error occurs, i've added another filter to crush thread

Related Issue

Sorry, i didn't create issue. You can check this bug fast before accepting or declining my pull request.

Motivation and Context

It fixes unexpected behavior.

How Has This Been Tested

It was tested on trading application.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the
    CONTRIBUTING
    document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@oliver-zehentleitner oliver-zehentleitner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

@oliver-zehentleitner oliver-zehentleitner merged commit 0f327f4 into LUCIT-Systems-and-Development:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants