Add two achievements for Treasures

Author: RussellLVP

javascript/features/collectables/README.md

@@ -30,6 +30,8 @@ Quick Addict      | Win 100 reaction tests         |
 Electrolyte       | Win 1,000 reaction tests       |
 The Streak        | Win 10 reaction tests in a row |
 keybind.cs        | Win a reaction test in <2s     |
+Blackbeard        | Collect 10 Treasures           |
+Jack Sparrow      | Collect all Treasures          |
 
 Beginning another round of earning the achievements _will not_ reset the benefits. Once granted, you
 will keep them indefinitely.

javascript/features/collectables/achievements.js

@@ -6,7 +6,7 @@ import { CollectableBase } from 'features/collectables/collectable_base.js';
 import { CollectableDatabase } from 'features/collectables/collectable_database.js';
 
 // -------------------------------------------------------------------------------------------------
-// Next ID: 9
+// Next ID: 16
 // -------------------------------------------------------------------------------------------------
 
 // Spray Tag achievements: awarded when the player gathers { 10, 40, 90, 100 } spray tags.
@@ -32,6 +32,10 @@ export const kAchievementReactionTestSequence = 12;
 // Reaction Test performance achievement: awarded when answering a reaction test super quickly.
 export const kAchievementReactionTestSpeed = 13;
 
+// Treasures achievements: awarded when the player gathers 10, or all, treasures.
+export const kAchievementTreasuresBronze = 14;
+export const kAchievementTreasuresPlatinium = 15;
+
 // -------------------------------------------------------------------------------------------------
 
 // Textual descriptions of the achievements that can be awarded by the game.
@@ -62,6 +66,10 @@ export const kAchievements = new Map([
       { name: 'The Streak', text: 'Won 10 reaction tests in a row' } ],
     [ kAchievementReactionTestSpeed,
       { name: 'keybind.cs', text: 'Won a reaction test in under two seconds' } ],
+    [ kAchievementTreasuresBronze,
+      { name: 'Blackbeard', text: 'Collect 10 Treasures' } ],
+    [ kAchievementTreasuresPlatinium,
+      { name: 'Jack Sparrow', text: 'Collect all the Treasures' } ],
 ]);
 
 // -------------------------------------------------------------------------------------------------

javascript/features/collectables/collectable_commands.test.js

@@ -30,7 +30,7 @@ describe('CollectableCommands', (it, beforeEach) => {
             rows: [
                 [
                     'Achievements',
-                    '2 / 13',
+                    '2 / 15',
                 ],
                 [
                     '{FF5252}Red Barrels',

javascript/features/collectables/treasures.js

@@ -9,6 +9,8 @@ import { Vector } from 'base/vector.js';
 import { createSeed, random, randomSeed } from 'base/random.js';
 import { intersect } from 'base/set_extensions.js';
 
+import * as achievements from 'features/collectables/achievements.js';
+
 // Title of the notification that will be shown to the player when finding a book, and another one
 // for the notification to be shown when a treasure associated with that book has been found.
 const kBookNotificationTitle = 'uncovered!';
@@ -380,7 +382,14 @@ export class Treasures extends CollectableBase {
     // Awards an achievement to the |player| when their collectable stats in the current round are
     // applicable to be awarded one. The thresholds are defined in achievements.js as well.
     awardAchievementWhenApplicable(player, collected) {
-        // TODO: Achievements?
+        const kMilestones = new Map([
+            [  10, achievements.kAchievementTreasuresBronze ],
+            [  50, achievements.kAchievementTreasuresPlatinium ],
+        ]);
+
+        const achievement = kMilestones.get(collected);
+        if (achievement)
+            this.collectables_.awardAchievement(player, achievement);
     }
 
     // ---------------------------------------------------------------------------------------------