Skip to content
Browse files

[Windows] Wait for the big icon to update on setIcon. This normally h…

…appens asynchronously, but we block until it's done and only then return from setIcon.
  • Loading branch information
Spasi committed Apr 19, 2013
1 parent 9a895b1 commit 6fd210fdb325b3acec17d46f8bb8d5ee12620785
Showing with 22 additions and 0 deletions.
  1. +22 −0 src/java/org/lwjgl/opengl/
@@ -83,6 +83,7 @@
private static final int WM_SYSKEYDOWN = 260;
private static final int WM_SYSCHAR = 262;
private static final int WM_CHAR = 258;
private static final int WM_GETICON = 0x007F;
private static final int WM_SETICON = 0x0080;
private static final int WM_SETCURSOR = 0x0020;
private static final int WM_MOUSEACTIVATE = 0x0021;
@@ -198,6 +199,7 @@

private long small_icon;
private long large_icon;
private boolean iconsLoaded;

private int captureMouse = -1;
private boolean trackingMouse;
@@ -779,6 +781,23 @@ public int setIcon(ByteBuffer[] icons) {
large_icon = large_new_icon;
done_large = true;

// Problem: The taskbar icon won't update until Windows sends a WM_GETICON to our window proc and we reply. But this method is usually called
// on init and it might take a while before the next call to nUpdate (because of resources being loaded, etc). So we wait for the next
// WM_GETICON message (usually received about 100ms after WM_SETICON) to make sure the taskbar icon has updated before we return to the user.
// (We wouldn't need to do this if the event loop was running continuously on its own thread.)
iconsLoaded = false;

// Track how long the wait takes and give up at 500ms, just in case.
long time = System.nanoTime();
long MAX_WAIT = 500L * 1000L * 1000L;
while ( true ) {
if ( iconsLoaded || MAX_WAIT < System.nanoTime() - time )


@@ -1060,6 +1079,9 @@ private long doHandleMessage(long hwnd, int msg, long wParam, long lParam, long
LWJGLUtil.log("WM_WINDOWPOSCHANGED: Unable to get window rect");
iconsLoaded = true;

return defWindowProc(hwnd, msg, wParam, lParam);

0 comments on commit 6fd210f

Please sign in to comment.
You can’t perform that action at this time.