-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binder -- Enable online viewing/running of Jupyter examples #107
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added simple in-line comments explaining changes
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 76.63% 70.28% -6.36%
==========================================
Files 36 36
Lines 3463 3463
Branches 741 741
==========================================
- Hits 2654 2434 -220
- Misses 618 843 +225
+ Partials 191 186 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change I think we need is the author/author_email fields of setup.py
, but there are a couple of places I'd like to start a conversation (and probably make issues for)
Looking at the notebooks, it looks like the synthesis didn't actually run? (all the progress bars say |
Yeah I see that too... strange. Maybe it's |
Ah yeah, that could definitely be it. Very strange. |
…ic into binder # Conflicts: # setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that util
import is necessary, but otherwise I think this is good to go.
Oh one other requested change: can you document somewhere the steps to get |
This will eventually get moved to a separate document, but so we have it for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me!
View / edit / reply to this conversation on ReviewNB ThomasYerxa commented on 2021-03-18T19:11:01Z could be just me but I couldn't see the most noticeable distortion at first, I guess that is the whole point but may want to consider cranking up the distortion factor? |
looks good to me, left one comment on the tutorial notebook that isn't related to this PR. |
Changes:
from tqdm.auto import tqdm
for nicer notebook formatting when running synthesis with eigendistortionspt.imshow
from notebookssetup.py
to torch<1.8 because steerpyr is breaking tons of steerpyr related tests bc of the torch.fft module, but Nikhil's future PR should fix it.