Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fb buildcontent 26859 #3

Merged
merged 6 commits into from Jan 12, 2017

Conversation

Projects
None yet
2 participants
@labkey-eyounske
Copy link
Contributor

commented Jan 10, 2017

No description provided.

labkey-eyounske added some commits Dec 22, 2016

Spec 26859: Build content reporting
  -- Re-enable wiki and messageboard modules but only as explicitly unsupported modules
  -- Update wiki and messageboard to run under Python 3 (not re-tested under Python 2, probably won't work)
  -- Changed internals of wiki and messageboard to be more like query and experiment (like using server_context)
  -- Various other cleanups
Spec 26859: Build content reporting
  -- Fix incorrect swapping of return codes
Spec 26859: Build content reporting
  -- Change get/post to use Requests instead of Session
  -- Change wiki url construction to use Requests instead of string concatenation

labkey-nicka added some commits Jan 11, 2017

Make unsupported separate python module
- change version recognition to allow local import
- wiki, messageboard changes:
PEP 8 standards,
switch to using server_context session rather than requests directly,
change documentation to match current python pattern
Add tests for unsupported
- change how mocks are declared
- introduce test_utils
@labkey-nicka

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2017

@labkey-eyounske I've made the changes we'd discussed as well as added test coverage for messageboard.post_message. If you could sync this branch and make the necessary modifications to pushToDownload then we can get this merged.

@labkey-eyounske

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2017

I have changed to pushToDownloadPage_testing.py to match this branch, re-tested, and everything looks good. Should be good to merge.

@labkey-nicka labkey-nicka merged commit 1dad790 into master Jan 12, 2017

@labkey-nicka labkey-nicka deleted the fb_buildcontent_26859 branch Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.