diff --git a/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx b/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx index e6329ad068..48ca9f30f7 100644 --- a/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx +++ b/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx @@ -243,7 +243,7 @@ export class AdvancedSettings extends React.PureComponent { const { field, showDefaultValueSettings } = this.props; - // GitHub Issue #783: we don't yet support default values in the App + // GitHub Issue #298: we don't yet support default values in the App if (isApp()) return false; // some domains just don't support default values diff --git a/packages/components/src/internal/components/domainproperties/models.test.ts b/packages/components/src/internal/components/domainproperties/models.test.ts index 349ccd495a..e1aac10ff1 100644 --- a/packages/components/src/internal/components/domainproperties/models.test.ts +++ b/packages/components/src/internal/components/domainproperties/models.test.ts @@ -1458,7 +1458,7 @@ describe('resolveBaseProperties', () => { expect(field.rangeURI).toBe(SAMPLE_TYPE.rangeURI); expect(field.required).toBe(true); - // GitHub Issue 787 + // GitHub Issue #656 field = DomainField.resolveBaseProperties({ name: 'SampleId', required: false }); expect(field.dataType).toBe(SAMPLE_TYPE); expect(field.conceptURI).toBe(SAMPLE_TYPE.conceptURI); diff --git a/packages/components/src/internal/components/domainproperties/models.tsx b/packages/components/src/internal/components/domainproperties/models.tsx index 901b6b9260..1a3a4ef5bc 100644 --- a/packages/components/src/internal/components/domainproperties/models.tsx +++ b/packages/components/src/internal/components/domainproperties/models.tsx @@ -1181,7 +1181,7 @@ export class DomainField field.dataType = SAMPLE_TYPE; field.conceptURI = SAMPLE_TYPE.conceptURI; field.rangeURI = SAMPLE_TYPE.rangeURI; - field.required = !!(raw.required ?? true); // GitHub Issue 787 + field.required = !!(raw.required ?? true); // GitHub Issue #656 } } diff --git a/packages/components/src/internal/components/samples/actions.ts b/packages/components/src/internal/components/samples/actions.ts index 3b657e1f19..2d12c4eb63 100644 --- a/packages/components/src/internal/components/samples/actions.ts +++ b/packages/components/src/internal/components/samples/actions.ts @@ -378,7 +378,7 @@ export function createSessionAssayRunSummaryQuery(sampleIds: number[]): Promise< assayRunsQuery = 'AssayRunsPerSampleChildFolder'; } - // GitHub Issue 748: need to account for the case with no sampleIds + // GitHub Issue #643: need to account for the case with no sampleIds let whereClause = 'WHERE RowId IN (' + sampleIds.join(',') + ')\n'; if (sampleIds.length === 0) { whereClause = 'WHERE 1 = 0\n'; // add where clause that will always result in zero rows