From 057ff14ffac9bf959ef3aff82efa2bd25cd86840 Mon Sep 17 00:00:00 2001 From: cnathe Date: Tue, 18 Nov 2025 09:28:57 -0600 Subject: [PATCH 1/2] Add/update links for the GitHub issues in /kanban/issues --- .../internal/components/domainproperties/AdvancedSettings.tsx | 2 +- .../src/internal/components/domainproperties/models.test.ts | 2 +- .../src/internal/components/domainproperties/models.tsx | 2 +- packages/components/src/internal/components/samples/actions.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx b/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx index e6329ad068..48ca9f30f7 100644 --- a/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx +++ b/packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx @@ -243,7 +243,7 @@ export class AdvancedSettings extends React.PureComponent { const { field, showDefaultValueSettings } = this.props; - // GitHub Issue #783: we don't yet support default values in the App + // GitHub Issue #298: we don't yet support default values in the App if (isApp()) return false; // some domains just don't support default values diff --git a/packages/components/src/internal/components/domainproperties/models.test.ts b/packages/components/src/internal/components/domainproperties/models.test.ts index 349ccd495a..78bf3cedc6 100644 --- a/packages/components/src/internal/components/domainproperties/models.test.ts +++ b/packages/components/src/internal/components/domainproperties/models.test.ts @@ -1458,7 +1458,7 @@ describe('resolveBaseProperties', () => { expect(field.rangeURI).toBe(SAMPLE_TYPE.rangeURI); expect(field.required).toBe(true); - // GitHub Issue 787 + // GitHub Issue 787 (https://github.com/LabKey/kanban/issues/787) field = DomainField.resolveBaseProperties({ name: 'SampleId', required: false }); expect(field.dataType).toBe(SAMPLE_TYPE); expect(field.conceptURI).toBe(SAMPLE_TYPE.conceptURI); diff --git a/packages/components/src/internal/components/domainproperties/models.tsx b/packages/components/src/internal/components/domainproperties/models.tsx index 901b6b9260..7d21ceab8a 100644 --- a/packages/components/src/internal/components/domainproperties/models.tsx +++ b/packages/components/src/internal/components/domainproperties/models.tsx @@ -1181,7 +1181,7 @@ export class DomainField field.dataType = SAMPLE_TYPE; field.conceptURI = SAMPLE_TYPE.conceptURI; field.rangeURI = SAMPLE_TYPE.rangeURI; - field.required = !!(raw.required ?? true); // GitHub Issue 787 + field.required = !!(raw.required ?? true); // GitHub Issue 787 (https://github.com/LabKey/kanban/issues/787) } } diff --git a/packages/components/src/internal/components/samples/actions.ts b/packages/components/src/internal/components/samples/actions.ts index 3b657e1f19..2fdf266e49 100644 --- a/packages/components/src/internal/components/samples/actions.ts +++ b/packages/components/src/internal/components/samples/actions.ts @@ -378,7 +378,7 @@ export function createSessionAssayRunSummaryQuery(sampleIds: number[]): Promise< assayRunsQuery = 'AssayRunsPerSampleChildFolder'; } - // GitHub Issue 748: need to account for the case with no sampleIds + // GitHub Issue 748: need to account for the case with no sampleIds (https://github.com/LabKey/kanban/issues/748) let whereClause = 'WHERE RowId IN (' + sampleIds.join(',') + ')\n'; if (sampleIds.length === 0) { whereClause = 'WHERE 1 = 0\n'; // add where clause that will always result in zero rows From afab74bbc6c12cc006d48e03680ba365107c6afb Mon Sep 17 00:00:00 2001 From: cnathe Date: Tue, 18 Nov 2025 14:40:04 -0600 Subject: [PATCH 2/2] remap kanban issue number to internal-issues number --- .../src/internal/components/domainproperties/models.test.ts | 2 +- .../src/internal/components/domainproperties/models.tsx | 2 +- packages/components/src/internal/components/samples/actions.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/components/src/internal/components/domainproperties/models.test.ts b/packages/components/src/internal/components/domainproperties/models.test.ts index 78bf3cedc6..e1aac10ff1 100644 --- a/packages/components/src/internal/components/domainproperties/models.test.ts +++ b/packages/components/src/internal/components/domainproperties/models.test.ts @@ -1458,7 +1458,7 @@ describe('resolveBaseProperties', () => { expect(field.rangeURI).toBe(SAMPLE_TYPE.rangeURI); expect(field.required).toBe(true); - // GitHub Issue 787 (https://github.com/LabKey/kanban/issues/787) + // GitHub Issue #656 field = DomainField.resolveBaseProperties({ name: 'SampleId', required: false }); expect(field.dataType).toBe(SAMPLE_TYPE); expect(field.conceptURI).toBe(SAMPLE_TYPE.conceptURI); diff --git a/packages/components/src/internal/components/domainproperties/models.tsx b/packages/components/src/internal/components/domainproperties/models.tsx index 7d21ceab8a..1a3a4ef5bc 100644 --- a/packages/components/src/internal/components/domainproperties/models.tsx +++ b/packages/components/src/internal/components/domainproperties/models.tsx @@ -1181,7 +1181,7 @@ export class DomainField field.dataType = SAMPLE_TYPE; field.conceptURI = SAMPLE_TYPE.conceptURI; field.rangeURI = SAMPLE_TYPE.rangeURI; - field.required = !!(raw.required ?? true); // GitHub Issue 787 (https://github.com/LabKey/kanban/issues/787) + field.required = !!(raw.required ?? true); // GitHub Issue #656 } } diff --git a/packages/components/src/internal/components/samples/actions.ts b/packages/components/src/internal/components/samples/actions.ts index 2fdf266e49..2d12c4eb63 100644 --- a/packages/components/src/internal/components/samples/actions.ts +++ b/packages/components/src/internal/components/samples/actions.ts @@ -378,7 +378,7 @@ export function createSessionAssayRunSummaryQuery(sampleIds: number[]): Promise< assayRunsQuery = 'AssayRunsPerSampleChildFolder'; } - // GitHub Issue 748: need to account for the case with no sampleIds (https://github.com/LabKey/kanban/issues/748) + // GitHub Issue #643: need to account for the case with no sampleIds let whereClause = 'WHERE RowId IN (' + sampleIds.join(',') + ')\n'; if (sampleIds.length === 0) { whereClause = 'WHERE 1 = 0\n'; // add where clause that will always result in zero rows