Issue 43754: SampleTypeDomainKind.hasNullValues override to filter out aliquot rows in "can field be made required" check #2583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=43754
If a sample type has aliquots, those rows inherit the field values from the parent sample. However in the check that determines if a field can be set as "required" it compares the total sample/row count agains the non-nulls. Since field values in the DB for aliquot samples will always be null, this results in all fields for that sample type not being able to be set as required, even if all parent samples have values for that field. This PR takes aliquot sample rows into account when getting the total row count (i.e. filtering out aliquots).
Changes