Skip to content

Conversation

@theSloopJohnB
Copy link
Contributor

@theSloopJohnB theSloopJohnB commented Sep 18, 2017

fixes #355
fixes LabVIEW-DCAF/DCAF-Project-Templates#103

This issue has made it into many of our modules through the dynamic template. This will fix that problem at the root cause.

Using fixes Matt pointed out in this PR: LabVIEW-DCAF/Scan-Engine-Module#47

@DCAF-Builder
Copy link
Contributor

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

@theSloopJohnB
Copy link
Contributor Author

Note for reviewers - the diff robot only shows one VI. For some reason LabVIEW is crashing while creating the other one. The VI above fixes the remove down to 0 case. The other VI is the init case which sets the index to -1 on initialization, so nothing is selected at first.

@dbendele dbendele self-requested a review September 21, 2017 19:20
@theSloopJohnB
Copy link
Contributor Author

There was some kind of issue with the VIP file. I rebased onto master and triggered a rebuild that will hopefully fix the issue.

@DCAF-Builder
Copy link
Contributor

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

Copy link
Contributor

@dbendele dbendele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for rebuilding the package!

changes behave great

Recommend block diagram comment in init VI to explain that MC Listbox value signaling property must be set after event registration

@DCAF-Builder
Copy link
Contributor

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

@LabVIEW-DCAF LabVIEW-DCAF deleted a comment from DCAF-Builder Sep 22, 2017
@LabVIEW-DCAF LabVIEW-DCAF deleted a comment from DCAF-Builder Sep 22, 2017
Copy link
Contributor

@dbendele dbendele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding comment

@gcodetechnology
Copy link

See issue #402 that was caused by this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index incorrectly set to 0 at init and after removing to 0 channels. Error on trying to remove a channel that doesn't exist

5 participants