-
Notifications
You must be signed in to change notification settings - Fork 6
Fixes table initialization and removal to set selected index to -1 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png:
|
|
Note for reviewers - the diff robot only shows one VI. For some reason LabVIEW is crashing while creating the other one. The VI above fixes the remove down to 0 case. The other VI is the init case which sets the index to -1 on initialization, so nothing is selected at first. |
cbc2820 to
e42dce4
Compare
|
There was some kind of issue with the VIP file. I rebased onto master and triggered a rebuild that will hopefully fix the issue. |
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png:
|
dbendele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for rebuilding the package!
changes behave great
Recommend block diagram comment in init VI to explain that MC Listbox value signaling property must be set after event registration
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png:
|
dbendele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding comment
|
See issue #402 that was caused by this fix. |



fixes #355
fixes LabVIEW-DCAF/DCAF-Project-Templates#103
This issue has made it into many of our modules through the dynamic template. This will fix that problem at the root cause.
Using fixes Matt pointed out in this PR: LabVIEW-DCAF/Scan-Engine-Module#47