[AL-5458] Add our own library to use Python json parser to parse ndjson #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/ndjson-to-jsonlines_AL-5458
branch
2 times, most recently
from
0ef110d to
f9e8376
Compare
vbrodsky
force-pushed
the
VB/ndjson-to-jsonlines_AL-5458
branch
2 times, most recently
from
d3e7a70 to
48915e9
Compare
vbrodsky
force-pushed
the
VB/ndjson-to-jsonlines_AL-5458
branch
from
48915e9 to
250fe87
Compare
vbrodsky
changed the title
vbrodsky
changed the title
vbrodsky
force-pushed
the
VB/ndjson-to-jsonlines_AL-5458
branch
9 times, most recently
from
4717e26 to
398f8b1
Compare
Added tests
vbrodsky
force-pushed
the
VB/ndjson-to-jsonlines_AL-5458
branch
from
398f8b1 to
f5d2b38
Compare
apollonin
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/AL-5458
This is the first step in replacing ndjson library with our own. This PR adds a new module that has exactly the same methods as we use in ndjson library BUT we implement them ourselves using Python json parser.
The is the same as ndjson uses, so the end result is very similar in terms of parsing and performance. I have added tests, where I generated expected results using the ndjson library