MAL Validation #112
Merged
MAL Validation #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
February 26, 2021 11:08
…into ms/validation
florijanstamenkovic
suggested changes
Mar 8, 2021
Contributor
florijanstamenkovic
left a comment
florijanstamenkovic
left a comment
There was a problem hiding this comment.
Initial fast review looking mostly at code organization and no logic.
Also, please name PR something more descriptive. Just "validate" can mean many things.
Contributor
florijanstamenkovic
left a comment
florijanstamenkovic
left a comment
There was a problem hiding this comment.
Still some things to fix up, please address.
added 2 commits
March 9, 2021 07:45
florijanstamenkovic
approved these changes
Mar 9, 2021
gszpak
reviewed
Mar 10, 2021
labelbox/exceptions.py
Outdated
Comment on lines
109
to
111
| class ValidationError(LabelboxError): | ||
| """Raised when user input is invalid for MAL imports.""" | ||
| ... |
Contributor
There was a problem hiding this comment.
Let's use a more descriptive name, e.g. AnnotationImportValidationError?
Contributor
Author
There was a problem hiding this comment.
That is kind of long. How is MALValidationError?
gszpak
approved these changes
Mar 10, 2021
added 2 commits
March 10, 2021 09:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.