Skip to content

Conversation

@kkim-labelbox
Copy link
Contributor

  • Reduced timeout for project._wait_until_data_rows_are_processed to 30s with sleep interval set to 5s
  • Reduced number of retries on github action from 5-->3, with reruns-delay from 10s-->3s
  • Removed @attila-papai 's _wait_until_data_rows_are_processed calls, since it's taken care of in create_batch

@kkim-labelbox kkim-labelbox requested review from a team, mnoszczak and yamini-labelbox June 22, 2023 01:37
@mnoszczak
Copy link
Contributor

Removed @attila-papai 's _wait_until_data_rows_are_processed calls, since it's taken care of in create_batch

@kkim-labelbox this was explicitly introduced to fix integration tests yesterday, can this change cause a test regression?

@kkim-labelbox
Copy link
Contributor Author

Removed @attila-papai 's _wait_until_data_rows_are_processed calls, since it's taken care of in create_batch

@kkim-labelbox this was explicitly introduced to fix integration tests yesterday, can this change cause a test regression?

@mnoszczak , this function is already embedded into create_batch(), so the tests should pass without it. The issue with integration tests yesterday was due to how ES count is fetched to determine which data rows are stuck in processing. That's been fixed in intelligence, so we should be good here

@kkim-labelbox kkim-labelbox merged commit c54cc8e into develop Jun 23, 2023
@kkim-labelbox kkim-labelbox deleted the kkim/fix-dr-processing-in-tests branch June 23, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants