Skip to content

Conversation

@vbrodsky
Copy link
Contributor

Removing feature_schema_id from exporter v2 tests

  1. This is a new field, BUT it is not a 'static' field thus can not assert the value
  2. However in the near future we should add an assertion on presence of the key

@vbrodsky vbrodsky requested a review from yamini-labelbox June 26, 2023 16:57
Copy link
Contributor

@yamini-labelbox yamini-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU so much for looking into this, val!

@vbrodsky
Copy link
Contributor Author

THANK YOU so much for looking into this, val!

of course... I am curious why this did not fail on merge

exported_annotations = exported_project_labels['annotations']

remove_keys_recursive(exported_annotations, ['feature_id'])
remove_keys_recursive(exported_annotations,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was occurring in different places, is this the only place where this needs to be updated?

@mnoszczak
Copy link
Contributor

Closing in favor of: #1153

@mnoszczak mnoszczak closed this Jun 26, 2023
@lhriley lhriley deleted the VB/fix-exporter-feature-schema-id branch September 1, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants