Skip to content

Conversation

@msokoloff1
Copy link
Contributor

@msokoloff1 msokoloff1 commented Mar 8, 2021

  • The goal of this PR is to check user input to the sdk. There are a few places where customer input fails and it isn't clear exactly what caused the error to occur

  • There was a bit of scope creep and a few other things got pulled in. It is kind of a large PR sorry.

  • Overivew of changes:

    • datarows now support image_overlay metadata type
    • Checks if metadata type is a valid when adding metadata to a data row
    • Fixes the dataset.data_rows_for_external_id bug.
      • Previously we would throw an error if a user has more than one data row with the same external id
    • Add warnings to deprecated functions
    • Supports webhook topics for reviews
    • Now checks if webhook topics are valid
    • Validate labeling parameter overrides args
    • Validates upsert_review_queue args
    • Improved / more descriptive doc strings

@msokoloff1 msokoloff1 changed the title Ms/validation part2 User input validation Mar 10, 2021
@msokoloff1 msokoloff1 requested a review from nmaswood March 10, 2021 23:34
Copy link

@nmaswood nmaswood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take another look first thing tmr :)

@msokoloff1 msokoloff1 requested review from gszpak and nmaswood March 11, 2021 02:16
@msokoloff1 msokoloff1 merged commit dd4530a into develop Mar 11, 2021
@msokoloff1 msokoloff1 deleted the ms/validation-part2 branch March 11, 2021 16:59
msokoloff1 added a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants