[AL-5942] Exports v2 integration tests #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamini-labelbox
changed the title
yamini-labelbox
force-pushed
the
yk/InTests
branch
6 times, most recently
from
1749dc8 to
58e277e
Compare
yamini-labelbox
force-pushed
the
yk/InTests
branch
from
328f4d8 to
d985579
Compare
vbrodsky
reviewed
Aug 10, 2023
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.parametrize('data_rows', [5], indirect=True) |
Contributor
There was a problem hiding this comment.
Why does this have to be 5 data rows? Can we reduce to 2?
Contributor
Author
There was a problem hiding this comment.
We can. Does it impact the the test run time by a large extent? (curious)
I am dropping it to 2 anyway.
Contributor
There was a problem hiding this comment.
well as I am working right now to optimize fixtures, it looks like the biggest bottleneck is creation of data rows, because this has to go to es and come back
I can not say that 2 vs 5 will make a world of difference, but generally I think we never need more than 2 data rows in our integration tests to represent the concept of 'many'.
| ]) == set(data_row_ids) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize('data_rows', [5], indirect=True) |
Contributor
Author
There was a problem hiding this comment.
changed it to 3. This test needs a min of 3 datarows.
vbrodsky
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://labelbox.atlassian.net/browse/AL-5942
tests/integration/annotation_import/test_data_types.py::test_import_data_types_v2 still has the exports v2 tests for all the datatypes. This test cases does testing for both import and export pipelines. So I let it be here for now. Although it is ideal to have a similar test case in the exports suite. But in view of not duplicating the test cases (which increases the run time), i let it be here. This is the only exports v2 related test case that is not inside the exports_v2 suite.