[AL-6733] Add ADV specific assertion #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attila-papai
commented
Aug 8, 2023
| task.wait_till_done() | ||
| assert task.status == "FAILED" | ||
| assert len(task.failed_data_rows) > 0 | ||
| if is_adv_enabled: |
Contributor
Author
There was a problem hiding this comment.
@kkim-labelbox another difference in ADV
I documented this here
Contributor
There was a problem hiding this comment.
Is this because ADV partially fails now when there's an error with validation of metadata on one data row?
Contributor
Author
There was a problem hiding this comment.
It partially succeeds instead. What can be imported, will be imported. The rest will be reported as failures.
attila-papai
requested review from
kkim-labelbox and
vbrodsky
and removed request for
kopreschko and
yamini-labelbox
shaochen-lb
reviewed
Aug 8, 2023
vbrodsky
reviewed
Aug 11, 2023
vbrodsky
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ADV import task won't fail when invalid metadata was given in the payload so a slightly different assertion is needed.