Remove sleep between creating and exporting a batch #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-python into attila/add-sleep-batch
attila-papai
changed the title
attila-papai
changed the title
mnoszczak
reviewed
Aug 17, 2023
| batch = project.create_batch("batch test", data_rows) | ||
|
|
||
| # give some time for the data ingestion system to finish processing the batch creation | ||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
Is there a way to check if batch adding has been completed? I understand that it makes sense to call time.sleep(X) before create_batch_async(), but why would we need to call it for create_batch()? If there's something that changed about the internals, it should be handled within create_batch() implementation IMO, so that the experience is still sync
Contributor
Author
There was a problem hiding this comment.
thanks for raising your concern here! It made me think if I could improve this in our backend systems instead and I managed to fix it in this PR
attila-papai
changed the title
attila-papai
changed the title
mnoszczak
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to improvement in this PR we no longer need the extra 5 seconds of delay between creating and exporting a batch.