[AL-6740] assert adv global key errors separately #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attila-papai
changed the title
vbrodsky
reviewed
Aug 17, 2023
| if is_adv_enabled: | ||
| assert res['status'] == 'PARTIAL SUCCESS' | ||
| assert len(res['results']) == 2 | ||
| assert len(res['errors']) == 1 |
Contributor
There was a problem hiding this comment.
curious why adv has 1 error vs 'legacy' 3
Contributor
Author
There was a problem hiding this comment.
due to a different global key sanitization logic implemented in ADV, but this PR is only to make the test green to enable UAT
in a follow up PR we will adjust the sanitization logic in ADV and alter these tests once again
mnoszczak
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we agree on the strategy regarding global key sanitization and validation in ADV, I fix this single failing test case to unblock further UAT. Follow up ticket: https://labelbox.atlassian.net/browse/AL-6929