Add sdk method to get data row by global key #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
requested review from
a team,
kopreschko,
mnoszczak and
yamini-labelbox
mnoszczak
reviewed
Sep 14, 2023
| Returns: DataRow: returns a single data row given the global key | ||
| """ | ||
|
|
||
| res = self.get_data_row_ids_for_global_keys([global_key]) |
Contributor
There was a problem hiding this comment.
Partial success is possible here and I think should be handled here as well
Contributor
Author
There was a problem hiding this comment.
Partial? But for this call we have only 1 global key (this is equivalent to client.get_data_row(data_row_id)
mnoszczak
approved these changes
Sep 14, 2023
Contributor
Author
|
Re: snyk issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story: https://labelbox.atlassian.net/browse/SDK-246
reusing existing sdk methods to first get the data row id by global key and then get the data row
following existing exception handling paradigm
added sdk integration test and manually tested failure scenarios
NOTE: there is currently no way in the API / ADV to get a data row by global key directly