Skip to content

Fix bulk_export() not exporting global_key(s) #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Fix bulk_export() not exporting global_key(s) #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d35944
fix
yamini-labelbox Sep 5, 2023
b71a2d1
consume globalkey returned by dataRowCustomMetadata GQL endpoint
yamini-labelbox Sep 27, 2023
4850b29
add integration test
yamini-labelbox Oct 12, 2023
14e6959
Merge branch 'develop' into yk/sdk198
yamini-labelbox Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion labelbox/schema/data_row_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,9 @@ def parse_metadata(
if "fields" in dr:
fields = self.parse_metadata_fields(dr["fields"])
parsed.append(
DataRowMetadata(data_row_id=dr["dataRowId"], fields=fields))
DataRowMetadata(data_row_id=dr["dataRowId"],
global_key=dr["globalKey"],
fields=fields))
return parsed

def parse_metadata_fields(
Expand Down Expand Up @@ -621,6 +623,7 @@ def _bulk_export(_data_row_ids: List[str]) -> List[DataRowMetadata]:
query = """query dataRowCustomMetadataPyApi($dataRowIds: [ID!]!) {
dataRowCustomMetadata(where: {dataRowIds : $dataRowIds}) {
dataRowId
globalKey
fields {
value
schemaId
Expand Down
12 changes: 12 additions & 0 deletions tests/integration/test_data_row_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,15 @@ def test_export_empty_metadata(client, configured_project_with_label,
assert label.data.metadata == []


def test_bulk_export_datarow_metadata(data_row, mdo: DataRowMetadataOntology):
metadata = make_metadata(data_row.uid)
mdo.bulk_upsert([metadata])
exported = mdo.bulk_export([data_row.uid])
assert exported[0].global_key == data_row.global_key
assert exported[0].data_row_id == data_row.uid
assert len([field for field in exported[0].fields]) == 3


def test_get_datarow_metadata_ontology(mdo):
assert len(mdo.fields)
assert len(mdo.reserved_fields)
Expand Down Expand Up @@ -316,6 +325,8 @@ def test_parse_raw_metadata(mdo):
example = {
'dataRowId':
'ckr6kkfx801ui0yrtg9fje8xh',
'globalKey':
'global-key-1',
'fields': [
{
'schemaId': 'cko8s9r5v0001h2dk9elqdidh',
Expand Down Expand Up @@ -344,6 +355,7 @@ def test_parse_raw_metadata(mdo):
assert len(parsed) == 1
for row in parsed:
assert row.data_row_id == example["dataRowId"]
assert row.global_key == example["globalKey"]
assert len(row.fields) == 4

for row in parsed:
Expand Down