Skip to content

Conversation

@richardsun0713
Copy link
Contributor

No description provided.

@richardsun0713 richardsun0713 requested review from a team, mnoszczak and vbrodsky October 3, 2023 22:56
res = self.client.execute(query_str, {id_param: self.uid})
return res["project"]["setLabelingParameterOverrides"]["success"]

def set_data_row_labeling_priority(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it creating something new or updating? In the latter case, we generally name methods like update_data_row_labeling_priority

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be update then - thanks!

project = consensus_project
dataset = initial_dataset

task = dataset.create_data_rows([{DataRow.row_data: image_url}] * 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a fixture to create data rows? Else, if the test fails, data rows are not deleted.

@richardsun0713 richardsun0713 merged commit 230341e into develop Oct 4, 2023
@richardsun0713 richardsun0713 deleted the rsun/QQC-2590 branch October 4, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants