Skip to content

Conversation

@ovalle15
Copy link
Contributor

@ovalle15 ovalle15 commented Feb 21, 2024

  • Included examples of uploading composite masks in image projects. To test please create an import with both Annotation types and NDJSON
  • Removed how to fetch a single instance mask since this will be deprecated, and for composite mask we have a different notebook demonstrating how to do this

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Gabefire
Copy link
Collaborator

image
Hey! I know this was not part of your PR but for the global_key on step 1 of the end to end. I think it would be better to do a str(uuid.uuid4()) instead of the image name. I often run into global key collisions because other notebooks uses this global key plus if I run the notebook again it would error out at that point. Let me know what you think!

"metadata": {},
"source": [
"### Segmentation Mask"
"### Composite mask upload using multiple tools \n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "using multiple methods" makes more sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about :
"Composite mask upload using different tools "
I am demonstrating how you can match colors to tools, so keeping the word tool is essential.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I know I just think of tools as in something more broad like an entire library/ module (git for example) were function/ method would be what this is in my mind. We can keep it though if you think it is essential and it is minor

"source": [
"### Segmentation Mask"
"### Composite mask upload using multiple tools \n",
"This example shows how to assigned different annotations (mask instances) from a composite mask using multiple tools"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch assigned to assign and maybe different methods instead of multiple tools

@ovalle15
Copy link
Contributor Author

ovalle15 commented Feb 26, 2024

re: #1431 (comment)
I think this is a feature, not necessarily an issue because it demonstrates the whole point of using global keys, which is avoiding uploading duplicate data.
The user can still use the data that exists in their organization without issues in the notebook

@Gabefire
Copy link
Collaborator

I agree it is a feature but I keep running into it and I figured since we are on this notebook we can explore that option as it pops up. I have to make sure I delete that data set and the unique id is a good practice to show.

@ovalle15
Copy link
Contributor Author

ovalle15 commented Feb 26, 2024

I totally get it ! I made some updates incorporating your suggestions ! @Gabefire

@Gabefire
Copy link
Collaborator

Looks good!

@ovalle15 ovalle15 merged commit 1527dc5 into develop Feb 26, 2024
@ovalle15 ovalle15 deleted the ao_sn120_updates_2 branch February 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants