[PLT-34] add support for custom embeddings to data import #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobers1982
force-pushed
the
mrobers1982/plt_34
branch
4 times, most recently
from
ceb14e1 to
6b5cce4
Compare
mrobers1982
commented
Mar 28, 2024
| vector: List[float] | ||
| clusters: Optional[List[int]] | ||
|
|
||
| def to_gql(self) -> Dict[str, Any]: |
Contributor
Author
There was a problem hiding this comment.
This is to convert snake_case (from Python) to camelCase (to GQL).
mrobers1982
force-pushed
the
mrobers1982/plt_34
branch
from
6b5cce4 to
4f7fc5a
Compare
sfendell-labelbox
approved these changes
Apr 3, 2024
mrobers1982
force-pushed
the
mrobers1982/plt_34
branch
from
4f7fc5a to
9118afe
Compare
mrobers1982
force-pushed
the
mrobers1982/plt_34
branch
from
9118afe to
ec0c525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://labelbox.atlassian.net/browse/PLT-34
This PR has a dependency on changes to our GQL API which can be found here: https://github.com/Labelbox/intelligence/pull/20258
Integration tests will fail until the above is merged and deployed to the corresponding environments.
Why are there no integration tests?
A custom embedding needs to be created in order to import a custom embedding with a data row.
Currently, the SDK does not support creating a custom embedding, this will happen as a separate item of work, i.e. deprecating the existing
advlibtool - this will begin in the very near future.I have tested this locally (using the UI to create the embedding) and it works correctly. If however, we need to include an integration test, I can look into importing the existing
advlibtool (for testing) to create the custom embedding or alternatively we wait until theadvlibtool is deprecated.