Skip to content

Conversation

@alexandracota
Copy link
Contributor

I added some samples to dataset.create_data_rows and dataset.create_data_row due to feedback from our support engineers that users are often confused by the documentation for these two. I also cleaned up the language a little bit.

Copy link
Contributor

@florijanstamenkovic florijanstamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, see minor suggestion!

Comment on lines 68 to 70
>>> dataset.create_data_rows([
{DataRow.row_data:"http://my_site.com/photos/img_01.jpg"},
"path/to/file2.jpg"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to:

>>> dataset.create_data_rows([
>>>     {DataRow.row_data:"http://my_site.com/photos/img_01.jpg"},
>>>     "path/to/file2.jpg"
>>> ])

Note the leading >>> in every line, and I just moved the final ]) to new line for even better readibility.

@alexandracota alexandracota merged commit 1e09e05 into develop Nov 25, 2019
@alexandracota alexandracota deleted the ac/docstrings branch November 25, 2019 18:35
msokoloff1 pushed a commit that referenced this pull request Sep 22, 2021
add code samples to dataset.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants