Change Order of operations in project.setup #24
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleowens10
approved these changes
Mar 9, 2020
rllin
pushed a commit
that referenced
this pull request
Jul 23, 2020
* Fix api_reference_generator deletion. * [fix] Project setup order of operations (#24) * Improve Exception handling. * Fix LabelboxError.__str__ * Add 30 min flag to export_labels. (#22) Co-authored-by: Alexandra Cota <alexandracota@Alexandras-MBP.localdomain> * Add CONTRIB.md (#26) * [BACKEND-766] upload with content type guess (#28) * wip * clean up * change log and bump version Co-authored-by: Florijan Stamenkovic <florijan.stamenkovic@gmail.com> Co-authored-by: TohnJhomas <49878111+TohnJhomas@users.noreply.github.com> Co-authored-by: Alex Cota <cota.alexandra14@gmail.com> Co-authored-by: Alexandra Cota <alexandracota@Alexandras-MBP.localdomain> Co-authored-by: Florijan Stamenković <florijan@toptal.com>
rllin
pushed a commit
that referenced
this pull request
Aug 5, 2020
* Fix api_reference_generator deletion. * [fix] Project setup order of operations (#24) * Improve Exception handling. * Fix LabelboxError.__str__ * Add 30 min flag to export_labels. (#22) Co-authored-by: Alexandra Cota <alexandracota@Alexandras-MBP.localdomain> * Add CONTRIB.md (#26) * [BACKEND-766] upload with content type guess (#28) * wip * clean up * change log and bump version * [BACKEND-825] github actions integration tests (#31) * Create python-package.yml * fix syntax errors * remove unused function * env key * test against prod * let tox manage pyenv for now * tox gh actions * install python * environ chooser * fix * move environ to conftest * environ * remove import * fix * fix * prod * fix * no comments * fix * fix * fix * fix * address comments * Update test_label.py * [BACKEND-826] yapf enforcer + yapf entire repo (#33) * Create python-package.yml * fix syntax errors * remove unused function * env key * test against prod * let tox manage pyenv for now * tox gh actions * install python * environ chooser * fix * move environ to conftest * environ * remove import * fix * fix * prod * fix * no comments * fix * fix * fix * fix * yapf in action * yapf * yapf * [BACKEND-828] github actions publish package upon release creation (#34) * Create python-package.yml * fix syntax errors * remove unused function * env key * test against prod * let tox manage pyenv for now * tox gh actions * install python * environ chooser * fix * move environ to conftest * environ * remove import * fix * fix * prod * fix * no comments * fix * fix * fix * fix * yapf in action * yapf * address comments * publish workflow * dev * 2.4.2dev * 2.4.2rc1 * install rc2 * works, reset * [BACKEND-829] fix content length (#30) * package data for upload properly to fix content length being incorrect for file uploads * basename -> filename * yapf * fix mypy * yapf * test coverage for video uploads * test video * clear parens * bump version to 2.4.2 (#35) * bump version * update change log * posargs * sleep longer * Added BulkImportRequest integration (#27) * Added method to create BulkImportRequest from dictionaries * Added method to upload local ndjson with predictions to Labelbox' GCS * Bugfix: field_type * Moved part of try block to else block * Removed UploadedFileType enum * Fix * Creating BulkImportRequest from url * Creating BulkImportRequest objects from objects and local file * Added ndjson validation + sending contentLength * Making relationships work for BulkImportRequest * Added tests for BulkImportRequests * Added test for BulkImportRequest.refresh() * Added docstrings * Updated changelog and setup.py * Vhanged test URL * Using existing URL in tests * Implemented BulkImportRequest.wait_till_done method * Actually sleeping * Bumped version to 2.4.3 * Yapfing the whole project * Made mypy happy * Made mypy happy one more time * freeze dependencies Co-authored-by: rllin <randall@labelbox.com> Co-authored-by: Florijan Stamenkovic <florijan.stamenkovic@gmail.com> Co-authored-by: TohnJhomas <49878111+TohnJhomas@users.noreply.github.com> Co-authored-by: Alex Cota <cota.alexandra14@gmail.com> Co-authored-by: Alexandra Cota <alexandracota@Alexandras-MBP.localdomain> Co-authored-by: Florijan Stamenković <florijan@toptal.com> Co-authored-by: Grzegorz Szpak <greg@labelbox.com>
msokoloff1
pushed a commit
that referenced
this pull request
Sep 22, 2021
msokoloff1
pushed a commit
that referenced
this pull request
Sep 22, 2021
* Fix api_reference_generator deletion. * [fix] Project setup order of operations (#24) * Improve Exception handling. * Fix LabelboxError.__str__ * Add 30 min flag to export_labels. (#22) Co-authored-by: Alexandra Cota <alexandracota@Alexandras-MBP.localdomain> * Add CONTRIB.md (#26) * [BACKEND-766] upload with content type guess (#28) * wip * clean up * change log and bump version Co-authored-by: Florijan Stamenkovic <florijan.stamenkovic@gmail.com> Co-authored-by: TohnJhomas <49878111+TohnJhomas@users.noreply.github.com> Co-authored-by: Alex Cota <cota.alexandra14@gmail.com> Co-authored-by: Alexandra Cota <alexandracota@Alexandras-MBP.localdomain> Co-authored-by: Florijan Stamenković <florijan@toptal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I noticed that project.setup is broken currently - if you run it on a pictor project, the LFO get attached but not normalized. This is fixed by ensuring that the Labeling Frontend is attached to the project before the options are created
Changes
Attach Labeling Frontend to Project before creating the Labeling Frontend Options
Testing
Tested locally on V4 and Pictor (staging) and had no issues