Skip to content

support unassigned splits #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022
Merged

support unassigned splits #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions labelbox/schema/model_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,7 @@ def assign_data_rows_to_split(self,
timeout_seconds=120):

split_value = split.value if isinstance(split, DataSplit) else split

if split_value == DataSplit.UNASSIGNED.value:
raise ValueError(
f"Cannot assign split value of `{DataSplit.UNASSIGNED.value}`.")

valid_splits = filter(lambda name: name != DataSplit.UNASSIGNED.value,
DataSplit._member_names_)
valid_splits = DataSplit._member_names_

if split_value not in valid_splits:
raise ValueError(
Expand Down
8 changes: 1 addition & 7 deletions tests/integration/annotation_import/test_model_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,7 @@ def test_model_run_split_assignment(model_run, dataset, image_url):
with pytest.raises(ValueError):
model_run.assign_data_rows_to_split(data_row_ids, "INVALID SPLIT")

with pytest.raises(ValueError):
model_run.assign_data_rows_to_split(data_row_ids, DataSplit.UNASSIGNED)

for split in ["TRAINING", "TEST", "VALIDATION", *DataSplit]:
if split == DataSplit.UNASSIGNED:
continue

for split in ["TRAINING", "TEST", "VALIDATION", "UNASSIGNED", *DataSplit]:
model_run.assign_data_rows_to_split(data_row_ids, split)
counts = Counter()
for data_row in model_run.model_run_data_rows():
Expand Down