-
Notifications
You must be signed in to change notification settings - Fork 68
[AL-2659] Inclusion of optional metadata parameter #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kkim-labelbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One comment
labelbox/schema/batch.py
Outdated
| }) for result in reader) | ||
| return (Entity.DataRow( | ||
| self.client, { | ||
| **result, 'customMetadata': result['metadata'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be result['customMetadata'], but can you double check by printing the result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataRow {'created_at': datetime.datetime(2022, 6, 1, 21, 13, 28, tzinfo=datetime.timezone.utc), 'external_id': '5668a62497e6edcd', 'media_attributes': {}, 'metadata': [DataRowMetadataField(schema_id='cl3w2pwsr000nj6ouhqebbf19', value=datetime.datetime(2021, 10, 13, 21, 1, 44, 34911, tzinfo=datetime.timezone.utc))], 'metadata_fields': [{'schemaId': 'cl3w2pwsr000nj6ouhqebbf19', 'name': 'capture_date', 'kind': 'CustomMetadataDateTime', 'value': '2021-10-13T21:01:44.034911Z'}], 'row_data': 'https://storage.googleapis.com/labelbox-datasets/open-images/data/5668a62497e6edcd.jpg', 'uid': 'cl3w355rxh5doj6ou1ftpffq7', 'updated_at': datetime.datetime(2022, 6, 1, 21, 13, 28, tzinfo=datetime.timezone.utc)}>
This is an example result. i think we said that customMetadata -> metadata which should be the flattened view while metadata_fields is the simplified version
Sorry, just realized this formatting is not great here.
kkim-labelbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.