Skip to content

Conversation

@mkozik-lb
Copy link
Contributor

Part of project paradigm set to release 2nd November. Ran e2e tests after doing the modifications to verify they still pass.


def create_project(self, **kwargs) -> Project:
def create_project(self,
queue_mode: Optional[QueueMode] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for ditching the kwargs pattern here?

Copy link
Contributor

@kkim-labelbox kkim-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkozik-lb mkozik-lb force-pushed the mkozik/qqc-772 branch 2 times, most recently from 9f4dad1 to ce841c1 Compare November 1, 2022 16:26
@mkozik-lb mkozik-lb merged commit f125573 into develop Nov 1, 2022
@mkozik-lb mkozik-lb deleted the mkozik/qqc-772 branch November 1, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants