Skip to content

Conversation

@ovalle15
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ovalle15 ovalle15 changed the title Update image.ipynb / image annotation import Update image.ipynb / image annotation import - new paradigm Oct 28, 2022
"id": "a6a048e8-b5fe-418b-aec4-829b5b6802e5",
"metadata": {
"id": "a6a048e8-b5fe-418b-aec4-829b5b6802e5"
},
Copy link
Contributor

@msokoloff1 msokoloff1 Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #15.    import uuid

not really your change, but you might want to consider cleaning up imports. uuid is a duplicate.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

"id": "a6a048e8-b5fe-418b-aec4-829b5b6802e5",
"metadata": {
"id": "a6a048e8-b5fe-418b-aec4-829b5b6802e5"
},
Copy link
Contributor

@msokoloff1 msokoloff1 Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.    mal_label_list = [li_label]

shouldn't this be called li_label_list?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for catching that !

1. Clean up imports
2. Fix name of label import 
3. other small issues.
@msokoloff1 msokoloff1 self-requested a review November 1, 2022 19:26
@msokoloff1 msokoloff1 merged commit 3ad0b78 into develop Nov 1, 2022
@msokoloff1 msokoloff1 deleted the ovalle15-patch-2 branch November 1, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants