Skip to content

Conversation

@apollonin
Copy link
Contributor

No description provided.

@apollonin apollonin requested review from a team, kkim-labelbox and msokoloff1 December 16, 2022 20:35
name (str): Name of metadata schema
Returns:
Metadata schema as `DataRowMetadataSchema` or dict, in case of nested metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in case of Enum metadata is probably more accurate
  • It'd be nice to provide an example output of calling get_by_name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have changed the text as you suggesting.
Separately, where do you want me to provide an example? I can not find any instance of Example in the repo. I will update the SDK doc of course after we release this version.

Copy link
Contributor

@kkim-labelbox kkim-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit comment, but otherwise looks great!

@apollonin apollonin merged commit f8e612d into develop Dec 19, 2022
@apollonin apollonin deleted the AL-4435-improve-metadata-get-by-name-method branch December 19, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants