Skip to content

Conversation

@ovalle15
Copy link
Contributor

Created examples with all the annotation types supported for videos Created all examples with new NDJSON format annotations

Created examples with all the annotation types supported for videos
Created all examples with new NDJSON format annotations
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -1,346 +1,825 @@
{
Copy link
Contributor

@msokoloff1 msokoloff1 Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nested classifications are supported. Otherwise this looks good!


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm I couldn't get it to work. I can take a look tomorrow again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, a global nested classification works.

@ovalle15 ovalle15 changed the title New annotation import format New annotation import format-video Jan 3, 2023
@@ -1,346 +1,1016 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    frame_bbox_with_checklist_subclass_ndjson = {

Can you just make a note here as to what we are doing. Just mention that we do not support classifications by name and that we will populate these later in the notebook.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !

@msokoloff1 msokoloff1 self-requested a review January 4, 2023 23:15
@ovalle15 ovalle15 merged commit 23352f4 into develop Jan 5, 2023
@ovalle15 ovalle15 deleted the ovalle15-patch-2 branch January 5, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants