Skip to content

[AL-0] Fix tests that were flaky due to label creation #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2022
Merged

[AL-0] Fix tests that were flaky due to label creation #819

merged 3 commits into from
Dec 23, 2022

Conversation

@kkim-labelbox
Copy link
Contributor

@kkim-labelbox kkim-labelbox commented Dec 22, 2022 •
edited by msokoloff1
Loading

  • Added a step to wait for label to finish processing in configured_project_with_label
  • Added a step to wait for data row to finish processing for tests that rely on media_attributes to be populated, specifically tests that use label exports (labels on data rows that have not been processed are not exported).

@kkim-labelbox kkim-labelbox merged commit 65e7e72 into develop Dec 23, 2022
@kkim-labelbox kkim-labelbox deleted the kkim/fix-flaky-label-creation-in-test branch December 23, 2022 00:27
whistler
whistler reviewed Dec 23, 2022
View reviewed changes
tests/integration/conftest.py
def func(client, data_row):
data_row_id = data_row.uid
timeout_seconds = 60
while True:
Copy link
Contributor

@whistler whistler Dec 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also use the retry package for this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@whistler whistler whistler left review comments

@msokoloff1 msokoloff1 msokoloff1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kkim-labelbox @whistler @msokoloff1