Skip to content

[AL-0] Fix test_data_rows.py that expects an error message from backend #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2023
Merged

[AL-0] Fix test_data_rows.py that expects an error message from backend #862

merged 2 commits into from
Jan 27, 2023

Conversation

@kkim-labelbox
Copy link
Contributor

@kkim-labelbox kkim-labelbox commented Jan 27, 2023 •
edited
Loading

SDK tests are failing bc error message thrown from backend is different

FAILED tests/integration/test_data_rows.py::test_data_row_bulk_creation_with_same_global_keys - AssertionError: assert 'Data rows
 contain duplicate global keys' == 'Data rows contain empty string or duplicate global keys, which are not allowed'

Also fixed tests that are failing due to embeddings sunsetting

@kkim-labelbox kkim-labelbox merged commit 01a151f into develop Jan 27, 2023
@kkim-labelbox kkim-labelbox deleted the kkim/fix-data-row-test branch January 27, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apollonin apollonin Awaiting requested review from apollonin

1 more reviewer

@attila-papai attila-papai attila-papai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkim-labelbox @attila-papai