Skip to content

Conversation

@paulnoirel
Copy link
Contributor

Add the support of an optional attachment_name parameter to data_row.create_attachment() to match JSON creation.

Example:

data_row.create_attachment(attachment_type="IMAGE_OVERLAY", attachment_value="https://storage.googleapis.com/labelbox-sample-datasets/Docs/cir.jpg")

data_row.create_attachment(attachment_type="IMAGE_OVERLAY", attachment_value="https://storage.googleapis.com/labelbox-sample-datasets/Docs/weeds.jpg", attachment_name="Weeds")

Note:

Specific tests were added to verify the creation of an attachment with or without a name.

@paulnoirel paulnoirel requested a review from cssetian February 13, 2023 16:19
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally can approve, also see Chris comments

@paulnoirel
Copy link
Contributor Author

@vbrodsky Thanks! Additional tests were implemented as per Chris' suggestion.

@paulnoirel paulnoirel merged commit 033906a into develop Feb 14, 2023
@paulnoirel paulnoirel deleted the pno/attachment_name branch February 14, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants