[QQC-1484] Support move to task action #919
Conversation
richardsun0713
commented
Feb 16, 2023
richardsun0713
commented
- Added new entity TaskQueue
- Added new methods in Project:
- Obtain a list of TaskQueues owned by the Project
- Move a list of data rows to a specified TaskQueue
labelbox/schema/project.py
Outdated
| if status != "COMPLETE": | ||
| raise LabelboxError(f"Data rows were not moved successfully") | ||
|
|
||
| def _wait_for_task(self, task_id: str): |
There was a problem hiding this comment.
Have you considered using our existing Task class for this? _wait_for_task looks similar to Task.refresh()
There was a problem hiding this comment.
The Task class is specialized to handle data rows as the result type, but I can make it work without breaking existing usages
tests/integration/conftest.py
Outdated
| """ | ||
| data_rows = [dr.uid for dr in list(dataset.data_rows())] | ||
| batch_project.create_batch("test-batch", data_rows) | ||
| editor = list( |
There was a problem hiding this comment.
Looks like a lot of the code after this is shared between this and configured_project_with_label. Could you create a helper function for the ontology setup + label creation part?
labelbox/schema/project.py
Outdated
| for field_values in task_queue_values | ||
| ] | ||
|
|
||
| def move_data_rows_to_task(self, data_row_ids: List[str], |
There was a problem hiding this comment.
nit: move_data_rows_to_task_queue sounds more accurate, or even add_data_rows_to_task_queue?
There was a problem hiding this comment.
I'll update it to move_data_rows_to_task_queue, but keep the action as move for consistency with the UI equivalent
labelbox/schema/project.py
Outdated
|
|
||
| status = self._wait_for_task(task_id) | ||
| if status != "COMPLETE": | ||
| raise LabelboxError(f"Data rows were not moved successfully") |
There was a problem hiding this comment.
Is there a way we can show the error message from the task to users?
| from labelbox.orm.model import Field | ||
|
|
||
|
|
||
| class TaskQueue(DbObject): |
There was a problem hiding this comment.
Please add this class as an entry in docs/source/index.rst to be indexed for readthedocs.
More details https://labelbox.atlassian.net/wiki/spaces/AIENG/pages/1721139216/Release+a+new+Python+SDK+Version#Documentation-Updates
| project.create_label = create_label | ||
| project.create_label() | ||
| label = wait_for_label_processing(project)[0] | ||
| ontology = _setup_ontology(project) |
| raise LabelboxError(f"Data rows were not moved successfully") | ||
| task = self._wait_for_task(task_id) | ||
| if task.status != "COMPLETE": | ||
| raise LabelboxError(f"Data rows were not moved successfully: " + |
There was a problem hiding this comment.
What type of Task is this job? Currently, Task.errors only returns value for a JSON Import task
labelbox/schema/task.py
Outdated
| """ | ||
| # TODO: We should handle error messages for export v2 tasks in the future. | ||
| if self.name != 'JSON Import': | ||
| if (self.name != 'JSON Import') & (self.name != 'Move data rows to step'): |
There was a problem hiding this comment.
@mnoszczak I'm going to add another exception here so we don't break your test, but let's aim to fix this for all tasks soon
richardsun0713
force-pushed
the
rsun/QQC-1484
branch
from
af6baf0 to
f185f4b
Compare
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
Code looks good to me. Please resolve the merge conflict, and make sure the SDK tests run
richardsun0713
force-pushed
the
rsun/QQC-1484
branch
2 times, most recently
from
079dfbe to
f51cf8d
Compare
richardsun0713
force-pushed
the
rsun/QQC-1484
branch
from
f51cf8d to
7195550
Compare
