Vb/remove UUID notebooks al 4862 #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
February 20, 2023 10:04
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vbrodsky
force-pushed
the
VB/remove-uuid-notebooks_AL-4862
branch
from
a4e2042 to
0b87dc7
Compare
whistler
approved these changes
Feb 20, 2023
| "metadata": {}, | ||
| "source": [ | ||
| "pairs = get_label_pairs(val_labels, labels_mea, filter_mismatch = True)\n", | ||
| "pairs = lb.get_label_pairs(val_labels, labels_mea, filter_mismatch = True)\n", |
Contributor
There was a problem hiding this comment.
Functions related to metrics are not included in the lb namespace since this has mostly been replaced by autometrics.
This is how it can be imported instead:
from labelbox.data.metrics.group import get_label_pairs
You can also leave out this change, I can fix this for the rest of Looks like this was the only case.get_label_pairs usages in notebooks.
Contributor
Author
There was a problem hiding this comment.
thanks, @whistler . I will do the import you suggest... o.w. the notebooks it broken (I will test it in python, since this notebook does not run to my knowlesge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA story: https://labelbox.atlassian.net/browse/AL-4862
This removes uuid generation from notebook ndjson. It is not necessarty any more because we already support filling in uuids in the prediction service
I WAS going to followup, in this PR, and remove uuid's from sdk tests and test harnesses, but that led to many tests failing. Most of our NDJSON serialization classes generate a uuid by default. And this is not a problem, since our effort goes to making our customer life simpler in notebooks in literal NDJSON strings... So the I have left the sdk tests as is, and when we use NDJSON objects, those will come with uuid pre-populated