[PTDT-1108] Added client method unarchive_root_schema_node

[Tim-Kerr]

How to test:

from labelbox import Client

client = Client(
    api_key=<LOCALHOST_API_KEY>,
    rest_endpoint="http://localhost:3000/api/api/v1")

res = client.unarchive_feature_schema_node(<ontology_id>, <feature_schema_id>)
print(res)

Given a valid API key that owns the valid ontology and root feature schema node expect True

• Important: Test unauthorized access *

Use a valid api key for a user in another org. Attempt to unarchive the root feature schema node belonging to another org. Expect to get a "404" response.

https://www.loom.com/share/379eaebf4f5c483fa0fc0ca6656475d9

[lgluszek]

please encode ontology_id and root_feature_schema_id using urllib.parse.quote

[Tim-Kerr]

Updated

[lgluszek]

Suggested change

	if response.status_code == 200:
	if response.status_code == requests.codes.ok:

[Tim-Kerr]

Udpated

[lgluszek]

This is the convention other methods follow

Suggested change

	"Failed unarchive root feature schema node: ", response.text)
	"Failed unarchive root feature schema node, message: ", response.text)

[Tim-Kerr]

Updated

[kkim-labelbox]

Could you add a test case for this function? Other than that, left a couple small comments!

[kkim-labelbox]

Can we specify in the docstring here that only root level feature schemas are unarchivable?

[Tim-Kerr]

Updated

[kkim-labelbox]

It's probably fine to return None here, since it'll just return true when successfully unarchived anyway. Unless there's a case where unarchived = false

[Tim-Kerr]

It'll return false if the user passes in a root feature schema id that does not belong to the ontology.

[kkim-labelbox]

If the response is false, maybe we can just raise an exception then with an error message indicating that the unarchive was unsuccessful? I know the docstring specifies the behavior, but customers may not necessarily check for the output of this function, so it may be safer to throw an explicit message indicating the behavior

[Tim-Kerr]

Updated

[kkim-labelbox]

You cna do:

if not unarchived

[kkim-labelbox]

actually I would just do

  if not bool(response.json()['unarchived']):
    raise labelbox.exceptions.LabelboxError(
                    "Failed unarchive the feature schema.")
  return

and set the function return type to None

[Tim-Kerr]

Updated