[PTDT-1106] Implemented delete_feature_schema_from_ontology client method #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
lgluszek
reviewed
Mar 2, 2023
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
The code looks good.
- Left a couple nit comments
- Could you add a test case for this endpoint? You can probably reference @lgluszek 's tests
Tim-Kerr
commented
Mar 6, 2023
Tim-Kerr
commented
Mar 6, 2023
labelbox/client.py
Outdated
| elif response_json['deleted'] == True: | ||
| logger.info( | ||
| 'Feature schema was successfully removed from the ontology') | ||
| return response_json |
Contributor
There was a problem hiding this comment.
Can we actually create an instance of DeleteFeatureFromOntologyResult as the return object, rather than returning response_json directly? This will ensure we have consistent typing and prevent API changes from breaking customer scripts, if there's additional fields added to the response json.
kkim-labelbox
approved these changes
Mar 6, 2023
Tim-Kerr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: In order to properly test this PR locally you need to pull down the PTDT-1106 Intelligence branch. This branch contains the endpoint referenced in this PR.
Created new client method:
remove_feature_schema_from_ontology(ontology_id, feature_schema_id)This method removes (or archives) a feature schema from an ontology.
How to test:
If successful prints a success message. If not successful prints the error response from the api.