Add logic to upload labels by project id to model run #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/upsert-labels-from-project_AL-2960
branch
from
458c7e3 to
e591dfd
Compare
vbrodsky
force-pushed
the
VB/upsert-labels-from-project_AL-2960
branch
from
e591dfd to
2070372
Compare
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
Left some comments. Nice job!
labelbox/schema/model_run.py
Outdated
|
|
||
| def _upsert_labels_by_label_ids(self, | ||
| label_ids: List[str], | ||
| timeout_seconds=3600): |
Contributor
There was a problem hiding this comment.
We don't need timeout_seconds here, since it's provided by the top-level function
whistler
reviewed
Mar 2, 2023
vbrodsky
force-pushed
the
VB/upsert-labels-from-project_AL-2960
branch
7 times, most recently
from
e3adf57 to
c260c8d
Compare
vbrodsky
force-pushed
the
VB/upsert-labels-from-project_AL-2960
branch
from
c260c8d to
978cb46
Compare
kkim-labelbox
approved these changes
Mar 9, 2023
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
LGTM, nice test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories: https://labelbox.atlassian.net/browse/AL-2960
This updates the ModelRun#upsert_labels as per this TDD section
NOTE: includes some corrections YAPF made me do