make sdk modular #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QeyCoder
commented
Jul 16, 2025
QeyCoder
commented
- Make SDK modular
- Integrate CI & claude review
- Add async file and GCs improvement
- Proper release cycle
- Make file
ximihoque
reviewed
Jul 21, 2025
ximihoque
reviewed
Jul 21, 2025
ximihoque
reviewed
Jul 21, 2025
ximihoque
reviewed
Jul 21, 2025
ximihoque
reviewed
Jul 21, 2025
| if enable_connection_pooling: | ||
| self._setup_session() | ||
|
|
||
| def _setup_session(self): |
Contributor
There was a problem hiding this comment.
we can extract these session based functions to a ClientBase class for abstraction. I saw similar methods in async_client so will benefit both, what do you think ?
Contributor
Author
There was a problem hiding this comment.
I agree that I have merged these.
ximihoque
requested changes
Jul 21, 2025
Contributor
ximihoque
left a comment
ximihoque
left a comment
There was a problem hiding this comment.
Looks good with minor comments.
- What will be the process to build and for anyone to use the updated SDK when we push any changes ? Can you put that in the PR description.
- Are the changes tested ?
Contributor
Author
|
These changes are only tested with test cases. I don't have data to test so need your help |
|
@ximihoque @QeyCoder Whats pending here? |
|
@ximihoque Whats still pending here? |
Contributor
|
Guys please remove my account from github repo. I am getting a lot of
notifications. Thanks a lot.
*Warm Regards,*
*Angan Sen*
📍 Bangalore, India
📧 ***@***.*** | 📞 +91 8105311221
…On Tue, 16 Sept 2025 at 12:50, Ximi Hoque ***@***.***> wrote:
Merged #8 <#8> into main.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGS4Z43Y35TV3DRBCHVNID3S624NAVCNFSM6AAAAACBUD6AK2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJZG4YTQMRXGM2DANI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.