Skip to content

Commit 0eb28a1

Browse files
kalenikaliaksandrtrflynn89
authored andcommitted
LibWeb: Delete unused BufferPolicy from fetch Request
This is no longer needed since all requests are unbuffered.
1 parent 16b0f1e commit 0eb28a1

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

Libraries/LibWeb/Fetch/Infrastructure/HTTP/Requests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ GC::Ref<Request> Request::clone(JS::Realm& realm) const
264264
new_request->set_prevent_no_cache_cache_control_header_modification(m_prevent_no_cache_cache_control_header_modification);
265265
new_request->set_done(m_done);
266266
new_request->set_timing_allow_failed(m_timing_allow_failed);
267-
new_request->set_buffer_policy(m_buffer_policy);
268267

269268
// 2. If request’s body is non-null, set newRequest’s body to the result of cloning request’s body.
270269
if (auto const* body = m_body.get_pointer<GC::Ref<Body>>())

Libraries/LibWeb/Fetch/Infrastructure/HTTP/Requests.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -159,13 +159,6 @@ class WEB_API Request final : public JS::Cell {
159159
Auto
160160
};
161161

162-
// AD-HOC: Some web features need to receive data as it arrives, rather than when the response is fully complete
163-
// or when enough data has been buffered. Use this buffer policy to inform fetch of that requirement.
164-
enum class BufferPolicy {
165-
BufferResponse,
166-
DoNotBufferResponse,
167-
};
168-
169162
// Members are implementation-defined
170163
struct InternalPriority { };
171164

@@ -335,9 +328,6 @@ class WEB_API Request final : public JS::Cell {
335328
m_pending_responses.remove_first_matching([&](auto gc_ptr) { return gc_ptr == pending_response; });
336329
}
337330

338-
[[nodiscard]] BufferPolicy buffer_policy() const { return m_buffer_policy; }
339-
void set_buffer_policy(BufferPolicy buffer_policy) { m_buffer_policy = buffer_policy; }
340-
341331
private:
342332
explicit Request(GC::Ref<HeaderList>);
343333

@@ -532,8 +522,6 @@ class WEB_API Request final : public JS::Cell {
532522

533523
// Non-standard
534524
Vector<GC::Ref<Fetching::PendingResponse>> m_pending_responses;
535-
536-
BufferPolicy m_buffer_policy { BufferPolicy::BufferResponse };
537525
};
538526

539527
WEB_API StringView request_destination_to_string(Request::Destination);

Libraries/LibWeb/HTML/EventSource.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,6 @@ WebIDL::ExceptionOr<GC::Ref<EventSource>> EventSource::construct_impl(JS::Realm&
7878
// 12. Set request's initiator type to "other".
7979
request->set_initiator_type(Fetch::Infrastructure::Request::InitiatorType::Other);
8080

81-
// AD-HOC: We must not buffer the response as the connection generally never ends, thus we can't wait for the end
82-
// of the response body.
83-
request->set_buffer_policy(Fetch::Infrastructure::Request::BufferPolicy::DoNotBufferResponse);
84-
8581
// 13. Set ev's request to request.
8682
event_source->m_request = request;
8783

0 commit comments

Comments
 (0)